adding labels and calibrate interface example #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
SamWitty
requested changes
Jan 22, 2024
There was a problem hiding this comment.
This looks great overall. I'm not sure why parameter_estimates is being called with 0 and 1 as arguments (or honestly why that doesn't throw an error). Could you change it to call with no arguments.
parameter_estimates().
Calling this multiple times will result in different outputs, which I believe is the intention of the two successive cells.
|
@SamWitty made the change you requested, ready for review |
sabinala
added
the
awaiting review
SamWitty
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example using the
calibrateinterface tointerfaces.ipynb, as well as markdown labels.Closes #437