adding error message to calibrate and test for no uncertainty in models - DO NOT MERGE #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-not-have-any-distributions-over-parameters
|
@SamWitty @JosephCottam did we decide this is no longer necessary? Feel free to close if so, but this PR is complete otherwise. |
sabinala
added
awaiting review
|
Yes, this will be subsumed by a follow-up PR that directly uses the existing model inventory. Let's just leave it here for now, we can close if/when that PR comes. |
SamWitty
changed the title
SamWitty
added
WIP
sabinala
deleted the
527-error-required-amr-used-to-calibrate-does-not-have-any-distributions-over-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an error message to calibrate when a model does not include uncertainty in any parameter values.
Closes #527