Allow for interventions on constant parameters #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWitty
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR fixes a bug found in #588 , in which interventions on constant parameters throws various output processing errors. This error occurred because the output processing was attempting to splice intervention assignments into a parameter that was never traced in Pyro, and thus never made its way to the logged output. The intervention was always correctly being applied (to the best of our knowledge), but errors occurred on output processing.
This PR addresses the problem by adding all deterministic parameters to the Pyro trace using
pyro.deterministic.This PR subsumes #594 , which introduced the test case.
closes #588