Topic/toml v4 #7
Closed
+249
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to ensure that valid ints don't parse though
|
All tests now work. |
|
Sorry, I've been not paying enough attention -- my bad. I'll look into this shortly. |
|
Merged it in, I'll update the CHANGELOG and bump the version of the package (you have broken/improved the API a little). Not sure if I will push to Hackage already, I want to meditate a bit on the changes you've made to the Types first (maybe we can discuss). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes up almost all of the tests, and gives newline tables and underscores in numbers, so it also makes it compatible with TOML v4 as far as I can tell.