Skip to content

Add a new var named GoID, which is the goroutine struct address, use … #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a new var named GoID, which is the goroutine struct address, use … #102

wants to merge 1 commit into from

Conversation

kayaklee
Copy link

Add a new var named GoID, which is the goroutine struct address, use it as goroutine id

lwithers
lwithers suggested changes Jan 8, 2017
View reviewed changes
Copy link

@lwithers lwithers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If merged, this change would prevent the use of seelog on any architectures except amd64. This would need to change to be more general; perhaps adding a fallback goID() definition that returns "not implemented" on other architectures?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lwithers lwithers lwithers requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kayaklee @lwithers