windows: more test / testutils fixups #1708
Merged
+195
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We usually rely on feature tests to skip certain portions of a test. This causes a lot of overhead when the feature tests would only be used by the unit tests. For that reason the info tests skip some tests based on the current kernel version. Extend this concept to other platforms by reusing the selection logic introduced for feature tests. Signed-off-by: Lorenz Bauer <[email protected]>
Add a cross-platform DupFD helper and use it from tests. Signed-off-by: Lorenz Bauer <[email protected]>
TestProgramTestRunInterrupt tests Linux specific behaviour around signal delivery. It doesn't make sense to run it on a different platform. The test was copied without making any changes. Signed-off-by: Lorenz Bauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testutils: make IsVersionLessThan cross platform
testutils: add DupFD helper
ebpf: run TestProgramTestRunInterrupt only on Linux