Fix codacy issues #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should work!
Everything works under macOS!
.net 5.0 is EOL; 6.0 is current; 7.0 is preview, but works flawlessly under macOS
Manually fixing what needs to be fixing for being able to merge. This is mostly to make sure there is some consistency across TargetFrameworks, now that .NET 5.0 and other libraries have been deprecated.
This will almost certainly continue to require manual merging by the package maintainers!
Also: newer version is better than mine! (because it uses the cool new operators from more recent versions of C#...)
It seems to be what is hiccuping Codacy!
cinderblocks
force-pushed
the
master
branch
4 times, most recently
from
647e246 to
03b8c13
Compare
cinderblocks
force-pushed
the
master
branch
2 times, most recently
from
d1df730 to
30cc082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My own modest contributions, mostly to satisfy codacy.
This PR doesn't merge yet, I'll have to see the detailed logs to understand why.