Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: override timed text duration #120

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

msheby
Copy link
Contributor

@msheby msheby commented Feb 10, 2023

Allow for a faux timed text duration when trying to align track lengths in CPL creation.

@jhursty
Copy link
Contributor

jhursty commented Dec 12, 2023

Please resubmit with just the new override duration feature.

@msheby
Copy link
Contributor Author

msheby commented Dec 12, 2023

Please resubmit with just the new override duration feature.

Similar to that other PR, I erred by not starting anew from master; an update will come.

@msheby msheby marked this pull request as draft December 13, 2023 04:58
@msheby msheby marked this pull request as ready for review December 13, 2023 05:03
@msheby
Copy link
Contributor Author

msheby commented Dec 13, 2023

Whee. Go ahead.

@msheby msheby marked this pull request as draft December 19, 2023 22:37
@msheby msheby marked this pull request as ready for review December 19, 2023 22:44
@msheby
Copy link
Contributor Author

msheby commented Dec 19, 2023

Can you click on the "files changed" tab and confirm this patch doesn't make changes to IMFCompositionPlaylist.cpp?

@jhursty
Copy link
Contributor

jhursty commented Dec 19, 2023

Ah ha! I was wondering where that comment went! I mistakenly entered that into the wrong project. IMFCompositionPlaylist is not a part of asdcplib. Comment removed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants