Skip to content

feat(protect): introduce strongly typed model interface#119

Merged
calvinbrewer merged 24 commits intomainfrom
bulk-models
Apr 8, 2025
Merged

feat(protect): introduce strongly typed model interface#119
calvinbrewer merged 24 commits intomainfrom
bulk-models

Conversation

@calvinbrewer
Copy link
Copy Markdown
Contributor

No description provided.

@calvinbrewer calvinbrewer marked this pull request as draft April 2, 2025 21:52
@calvinbrewer calvinbrewer marked this pull request as ready for review April 4, 2025 15:17
@calvinbrewer calvinbrewer requested a review from auxesis April 4, 2025 15:25
Copy link
Copy Markdown
Contributor

@auxesis auxesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved, thanks @calvinbrewer.

All of my edits are minor documentation fixes.

async () => {
const { client, models, table } = this.operation.getOperation()

logger.debug('Bulk encrypting models WITH a lock context', {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling this out explicitly in logs is good ❤️

calvinbrewer and others added 17 commits April 8, 2025 07:26
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
@calvinbrewer calvinbrewer merged commit 5fe9d30 into main Apr 8, 2025
1 check passed
@calvinbrewer calvinbrewer deleted the bulk-models branch April 8, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants