ADLC-45: pin @supabase/ssr and @supabase/supabase-js to explicit versions - #51
Open
eltontay-circle wants to merge 1 commit into
Open
ADLC-45: pin @supabase/ssr and @supabase/supabase-js to explicit versions#51eltontay-circle wants to merge 1 commit into
eltontay-circle wants to merge 1 commit into
Conversation
…rsions Both packages were specified as the floating "latest" tag, which is non-reproducible and can break builds when upstream publishes a new release. Pin each to the version already resolved in package-lock.json so this is a pin rather than an upgrade: @supabase/ssr latest -> 0.8.0 @supabase/supabase-js latest -> 2.93.3 The lockfile change is limited to the two matching specifier strings in the root dependencies block. A full `npm install` rewrite was rejected because it churns ~5900 unrelated lines; the same churn reproduces on an unmodified master, so it reflects pre-existing lockfile drift. ADLC-45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the floating
latesttag on two dependencies with the exact versions already resolved inpackage-lock.json. This is a pin, not an upgrade — the resolved versions are unchanged.@supabase/ssrlatest0.8.0@supabase/supabase-jslatest2.93.3Exact versions with no caret, deliberately: a caret range would reintroduce the float this ticket exists to remove.
Verified the pin is not an upgrade — after installing,
npm lsreports@supabase/ssr@0.8.0and@supabase/supabase-js@2.93.3, identical to whatlatestresolved to before the change.Jira: https://circlepay.atlassian.net/browse/ADLC-45
Why the lockfile diff is only two lines
Running a plain
npm installrewritespackage-lock.jsonby roughly 5,900 lines — re-resolvingnext(also onlatest) and many caret ranges, and dropping/re-adding large parts of the tree.I confirmed this churn is pre-existing drift, not a side effect of this pin:
npm installon a clean, unmodifiedmastercheckout produces the same ~5,805 insertion / ~5,967 deletion diff with zero source changes.Committing that would violate the "no unrelated changes" requirement, so the lockfile edit here is confined to the two matching specifier strings in the root
dependenciesblock. Thepackages[""].dependenciesentries now agree withpackage.json, and the installed versions already satisfy them.One related note: because
package.jsonhas nonamefield,npm installalso rewrites the lockfile's top-levelnameto match the working directory. That is another reason the full rewrite was not committed.Verification
npm run lint— passes, exit 0, zero findings.npm run build— fails, both before and after this change, for reasons unrelated to it. On a pristinemastercheckout with no modifications, the build fails identically:The failure output on this branch is byte-identical to that baseline, so this PR introduces no regression.
Since the build halts at the first type error, I ran a full
tsc --noEmiton both the baseline and this branch to get complete coverage. Both produce the same three errors, all undeclared dependencies:Notably there are no Supabase-related type errors, which is the meaningful signal that the pinned versions typecheck cleanly against this codebase.
@radix-ui/react-checkbox,cmdk, andreact-hook-formare each imported by acomponents/ui/file but declared in neitherpackage.jsonnor the lockfile. Fixing that is outside this ticket's scope, so it is flagged rather than bundled here.Reviewer notes
lint-and-testjob in.github/workflows/ci.ymlruns onlynpm install— despite its name it runs neither the build nor the linter, and thescan/release-sbomjobs are commented out. A green check proves only that the tree installs. The lint and typecheck evidence above is from local runs.npm cicannot be used as a gate on this repo: it already fails on unmodifiedmasterwith a large set of@solana/*"Invalid"/"Missing" mismatches. Also pre-existing and unrelated.nextremains onlatestinpackage.json— the same class of problem, intentionally left alone per this ticket's scope. Worth a follow-up, and it needs a deliberate compatibility check againsteslint-config-next, which is pinned to15.3.1.