fix: add timeout to infinite polling loops to prevent hung requests - #39
Open
memosr wants to merge 1 commit into
Open
fix: add timeout to infinite polling loops to prevent hung requests#39memosr wants to merge 1 commit into
memosr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two functions in
lib/circle/gateway-sdk.tsusewhile (true)loops with no max retry count:waitForTransactionConfirmation(line 298) — polls every 2s indefinitelytransferUnifiedBalanceCircle(line 885) — polls every 3s indefinitelyA stuck transaction or unresponsive Circle API can hang the HTTP request forever — particularly problematic in serverless environments where requests hit the timeout wall but the underlying loop keeps spinning.
The EOA path at line 791 already correctly caps polling at 60 attempts (5 minutes total). The two infinite loops should match this pattern.
Fix
Applied the same retry-limit pattern to both functions:
Same pattern applied to
transferUnifiedBalanceCircle.Also standardized polling intervals to 5 seconds across all three functions (matching the EOA path) for consistency.
Impact