fix: recreate EVM adapter on account change - #46
Draft
danilaverbena wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
createViemAdapterFromProviderlazily caches the connected account. The hook previously recreated the adapter only when the provider identity changed, while merely recording address changes inlastAddressRef. Switching accounts in the same wallet therefore left Bridge Kit using an adapter bound to the previous account.The effect also declared a cancellation flag without registering cleanup, allowing an older asynchronous initialization to overwrite the adapter selected by a newer render.
This change keeps the adapter account aligned with the address shown by Wagmi and prevents stale initialization races.
Validation
npm run buildnpm run lint(0 errors; one pre-existing unrelated warning insrc/components/theme-provider.tsx)git diff --check