Skip to content

Commit

Permalink
Modify Sharepoint policies to only execute when applicable (#1076)
Browse files Browse the repository at this point in the history
* create consolidated method for getting sharepoint slider setting; begin rewriting unit tests

* add test cases to test against N/A cases where external sharing is not set to Anyone; add standard baseline check

* build at baseline test to match against new unit tests

* Complete new rego evaluation for sharepoint 3.1, modify existing rulesets, and adjust unit tests

* clean up, add comments

* modify functional test harness for sharepoint 3.1

* modify pnp functional tests

* update naming conventions for unit tests

* rename unit tests; refactor PolicyNotApplicable3_1 so that it can be reused for policies 3.2 / 3.3

* add N/A case for Sharepoint 3.2

* modify sharepoint 3.2 to check not applicable case, add unit tests to test for N/A

* modify unit tests for sharepoint 3.3; refactor ExpirationTimersVerificationCode() fnc to VerificationCodeReAuthExpiration fnc; handle not applicable case

* had to adjust which SharingCapability settings are applied in sharepoint 3.3

* in current state all unit tests pass

* refactor NA check into CheckPolicyNotApplicable fnc

* adjust sharepoint 3.3 NA results to include existing guests

* update functional tests cases for sharepoint 3.3 spo

* update pnp functional tests for sharepoint 3.3; all tests pass

* fix yaml linter

* change sharepoint 3.2 to check View as condition

* modify sharepoint 1.3 to take into account N/A case; modify unit tests to reflect change

* complete functional testing for sharepoint 1.3 for both spo/pnp variants

* clean up code

* fix 1.4

* fix unit tests

* update functional tests

* add missing unit tests

* update bad test titles

* improve test coverage

* remove unecessary settings in functional tests

---------

Co-authored-by: Sloane4 <[email protected]>
  • Loading branch information
mitchelbaker-cisa and Sloane4 committed May 9, 2024
1 parent 80ff62f commit b717d6c
Show file tree
Hide file tree
Showing 6 changed files with 761 additions and 299 deletions.
Loading

0 comments on commit b717d6c

Please sign in to comment.