Disable MS.SHAREPOINT.3.2v1 functional tests temporarily

[schrolla]

🗣 Description

Comments out the MS.SHAREPOINT.3.2v1 functional tests until the issue with toggling settings via the API can be resolved.

💭 Motivation and context

Should ensure the scheduled automated functional test runs don't regularly fail due to false positives when the SharePoint API does not toggle the test setting appropriately prior to this test. Long term, pursuing other workarounds and solutions such that these tests can be re-enabled. For now, manual testing is still possible using these tests.

Closes #1459

🧪 Testing

In order the validate that this improves the running of SharePoint functional tests, run the SharePoint PnP variant plan manually and repeat on as many tenants as necessary to ensure it finishes without error.

Can use ScubaGearCheck.ps1 script to automate run with following command line. Assumes that you already have service principal setup and have added thumbprint as default for ScubaGearCheck.ps1 you are running by editing the script.

ScubaGearCheck.ps1 -baseline sharepoint -Tenant 2 -UserAuth:$false -Variant pnp

✅ Pre-approval checklist

• This PR has an informative and human-readable title.
• PR targets the correct parent branch (e.g., main or release-name) for merge.
• Changes are limited to a single goal - eschew scope creep!
• Changes are sized such that they do not touch excessive number of files.
• All future TODOs are captured in issues, which are referenced in code comments.
• These code changes follow the ScubaGear content style guide.
• Related issues these changes resolve are linked preferably via closing keywords.
• All relevant type-of-change labels added.
• All relevant project fields are set.
• All relevant repo and/or project documentation updated to reflect these changes.
• Unit tests added/updated to cover PowerShell and Rego changes.
• Functional tests added/updated to cover PowerShell and Rego changes.
• All relevant functional tests passed.
• All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

• PR passed smoke test check.

• Feature branch has been rebased against changes from parent branch, as needed

  Use Rebase branch button below or use this reference to rebase from the command line.

• Resolved all merge conflicts on branch

• Notified merge coordinator that PR is ready for merge via comment mention

• Demonstrate changes to the team for questions and comments.
  (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

• Feature branch deleted after merge to clean up repository.
• Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

[ehaines1]

I realize you only changed the 3.2 tests, and as expected, they don't run. But in tenant 2, the 3.3 tests randomly fail. Maybe that series should also be temporarily disabled?

It is possible that since it's the transition from Disabled to another value for SharingCapability that causes the issue, that disabling 3.2 only pushes the problem to the next set of tests. I didn't run into it in my testing, but the intermittent nature means I may just have gotten unlucky during my runs. But I also couldn't reproduce it here with five additional runs either.
So, for now, I'd say we continue with just 3.2 disabled and I'll continue to watch daily functional test results. If I start seeing 3.3 becoming the squeaky wheel, then I'll consider more drastic changes. But for now I'm trying to disable the least amount of tests necessary.

[nanda-katikaneni]

Branch correctly omits the one test that randomly fails - approved.
Will add a comment to the spo issue tracking the random failures to re-add this test when the random failures are fixed.

[ehaines1]

Watch and see is a good way to go. There are still many unanswered questions about the sharepoint API bug