Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ScubaGear module version from v1.4.0 to v1.5.0 #1465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 9, 2024

🗣 Description

  • This PR was create by a GitHub Action to bump ScubaGear's module version in the manifest and the README.
  • Please fill out the rest of the template that the Action did not cover.

💭 Motivation and context

  • Bump ScubaGear's module version to v1.5.0 before the next release

🧪 Testing

  • A human should still check if the version bumping was successful by running ScubaGear.
  • Check that the HTML report shows 1.5.0 in both the summary and individual reports
  • Check the ScubaResults.json to ensure it embeds the correct version
  • Run Invoke-Scuba -Version and ensure it reports 1.5.0
  • Search documentation and code for signs of previous version number (Note: Sample report will be updated in separate PR)

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

  • Demonstrate changes to the team for questions and comments.
    (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@github-actions github-actions bot added the version bump This issue or pull request increments the version number label Dec 9, 2024
@schrolla schrolla added this to the Kraken milestone Dec 9, 2024
@schrolla schrolla self-requested a review December 9, 2024 15:12
Copy link
Collaborator

@schrolla schrolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed version updates through execution showing that:

  • Invoke-Scuba -Version shows 1.5.0
  • HTML reports show 1.5.0
  • ScubaResults.json shows ToolVersion 1.5.0
  • Manifest version is 1.5.0
  • Documentation shows 1.5.0
  • Search of repository does not show 1.4.0 (except in sample reports to be updated in separate PR)
    Looks good.

@schrolla schrolla self-assigned this Dec 9, 2024
@james-garriss
Copy link
Collaborator

Verified everything listed in the "Testing" section above.

@schrolla schrolla force-pushed the scubagear-version-bump-1.5.0 branch from ac3b7bf to 3395020 Compare December 10, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version bump This issue or pull request increments the version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants