do not mutate object state in the SpecChangePredicate

cisco-open · Oct 21, 2020 · 4253c2e · 4253c2e
1 parent e912066
commit 4253c2e
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/reconciler/predicates.go b/pkg/reconciler/predicates.go
@@ -72,7 +72,10 @@ type SpecChangePredicate struct {
 }
 
 func (SpecChangePredicate) Update(e event.UpdateEvent) bool {
-	e.MetaNew.SetResourceVersion(e.MetaOld.GetResourceVersion())
+	oldRV := e.MetaOld.GetResourceVersion()
+	e.MetaOld.SetResourceVersion(e.MetaNew.GetResourceVersion())
+	defer e.MetaOld.SetResourceVersion(oldRV)
+
 	patchResult, err := patch.DefaultPatchMaker.Calculate(e.ObjectOld, e.ObjectNew, patch.IgnoreStatusFields(), IgnoreManagedFields())
 	if err != nil {
 		return true