repair fx-/wraparound with 0 first argument, allow one argument
#899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `fx-/wraparound` function was treated like R6RS `fx-` by cp0, which meant that it could reduce a 2-argument call with `0` as the first argument to a 1-argument call, even though `fx-/wraparound` was defined with only a 2-argument form. Making `fx-/wraparound` more like R6RS `fx-` seems like the path of least resistance and least likelihood of future bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fx-/wraparoundfunction was treated like R6RSfx-by cp0, which meant that it could reduce a 2-argument call with0as the first argument to a 1-argument call, even thoughfx-/wraparoundwas defined with only a 2-argument form. Makingfx-/wraparoundmore like R6RSfx-seems like the path of least resistance and least likelihood of future bugs.