-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean config
parameters
#276
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: wthrajat <[email protected]>
Signed-off-by: wthrajat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks for doing this cleanup.
Our configs looks much better simpler and saner now.
Few more comments and its good to go.
Signed-off-by: wthrajat <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 79.65% 74.80% -4.86%
==========================================
Files 32 32
Lines 4945 4362 -583
==========================================
- Hits 3939 3263 -676
- Misses 1006 1099 +93 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
Aims to fix #248
MakerConfig
andTakerConfig
that should not be exposed to users.maker/server.rs
.taker/api.rs
.directory_server_onion_address
anddirectory_server_clearnet_address
fields with a unifieddirectory_server_address
field for bothMakerConfig
andTakerConfig
.required_confirms
to a default value of1
forMakerConfig
, removing it from user-facing configuration options.