Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean config parameters #276

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

wthrajat
Copy link
Collaborator

@wthrajat wthrajat commented Oct 10, 2024

Aims to fix #248

  • Removed internal parameters from MakerConfig and TakerConfig that should not be exposed to users.
  • Hardcoded default values for internal parameters in maker/server.rs.
  • Hardcoded default values for internal parameters in taker/api.rs.
  • Replaced separate directory_server_onion_address and directory_server_clearnet_address fields with a unified directory_server_address field for both MakerConfig and TakerConfig.
  • Set required_confirms to a default value of 1 for MakerConfig, removing it from user-facing configuration options.
  • Adjusted the code to use the constants rather than the struct fields.
  • Added documentation wherever needed.

Signed-off-by: wthrajat <[email protected]>
@wthrajat wthrajat self-assigned this Oct 10, 2024
@wthrajat wthrajat marked this pull request as draft October 10, 2024 12:23
@wthrajat wthrajat marked this pull request as ready for review October 29, 2024 13:26
Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for doing this cleanup.

Our configs looks much better simpler and saner now.

Few more comments and its good to go.

src/maker/config.rs Outdated Show resolved Hide resolved
src/maker/config.rs Show resolved Hide resolved
src/maker/config.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 58.49057% with 22 lines in your changes missing coverage. Please review.

Project coverage is 74.80%. Comparing base (2f9f0aa) to head (0bbacec).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/taker/api.rs 48.00% 13 Missing ⚠️
src/maker/server.rs 44.44% 5 Missing ⚠️
src/taker/routines.rs 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   79.65%   74.80%   -4.86%     
==========================================
  Files          32       32              
  Lines        4945     4362     -583     
==========================================
- Hits         3939     3263     -676     
- Misses       1006     1099      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean Config Params.
3 participants