Skip to content

Update pre-commit and fix some warnings/errors #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update pre-commit and fix some warnings/errors #408

wants to merge 3 commits into from

Conversation

kurtmckee
Copy link
Contributor

@kurtmckee kurtmckee commented Aug 19, 2025 •
edited
Loading

This PR introduces the following changes:

  • Run pre-commit autoupdate to update all hook versions

    This resolves warnings associated with out-of-date hook versions.

  • Fix ruff lint warnings regarding deprecated configuration values

  • Fix prospector lint errors regarding whitespace in f-string substitutions

There are three errors found by markdown-link-check that have not been addressed. These need to be addressed separately:

ERROR: 1 dead links found in README.dev.md !
[✖] https://github.com/citation-file-format/cffconvert/blob/main/cffconvert/behavior_shared/schemaorg_author_shared.py → Status: 404

ERROR: 3 dead links found in README.md !
[✖] https://pypistats.org/packages/cffconvert → Status: 502
[✖] https://github.com/citation-file-format/cffconvert/actions/workflows/testing.yml/badge.svg → Status: 404
[✖] https://github.com/citation-file-format/cffconvert/actions/workflows/linting.yml/badge.svg → Status: 404

Fixes #405

@kurtmckee
Run pre-commit run -a
d2dee3b
@kurtmckee
Address ruff warnings
ac40237 
Found while running pre-commit in verbose mode:

```shell
$ pre-commit run -av ruff
...
warning: The top-level linter settings are deprecated
in favour of their counterparts in the `lint` section.
Please update the following options in `pyproject.toml`:
  - 'select' -> 'lint.select'
  - 'flake8-quotes' -> 'lint.flake8-quotes'
```
@kurtmckee
Address prospector errors
90b31d9 
Found while running pre-commit:

```shell
$ pre-commit run -av prospector

...

src/cffconvert/cli/rawify_url.py
  Line: 23
    pycodestyle: E201 / whitespace after '{' (col 60)
    pycodestyle: E202 / whitespace before '}' (col 66)

src/cffconvert/cli/read_from_url.py
  Line: 18
    pycodestyle: E201 / whitespace after '{' (col 52)
    pycodestyle: E202 / whitespace before '}' (col 58)

...
```

Fixes citation-file-format#405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pre-commit fails on main
1 participant
@kurtmckee