fix(natives): Vector3 will generate a tuple type instead of an array … #2439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
The vector3 type has until now been generated as an array type. In my opinion it should be generated as a tuple type instead.
The reason I think the tuple type is a better option is because it can be used properly with the spread operator in functions that takes in the x, y and z component (ref picture below)
How is this PR achieving the goal
Changing the codegen for dts files to parse the Vector3 type into the tuple type
This PR applies to the following area(s)
Natives
Successfully tested on
Has not been tested due to node-gyp not being able to compile the libclang bindings in native-doc-tooling
Game builds: N/A
Platforms: Windows
Checklist
Fixes issues
N/A