Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mono/redm): initial works for rdr #2488

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

AvarianKnight
Copy link
Contributor

@AvarianKnight AvarianKnight commented Apr 26, 2024

Goal of this PR

Add same helper methods that FiveM has

How is this PR achieving the goal

Start implementing base classes for RedM.

This PR applies to the following area(s)

RedM, SCRT:C#

Successfully tested on

Game builds: 1491

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Apr 26, 2024
@AvarianKnight AvarianKnight force-pushed the feat/rdr3-mono branch 2 times, most recently from a3b203e to a87ae2c Compare April 27, 2024 05:43
@AvarianKnight AvarianKnight marked this pull request as ready for review April 27, 2024 05:44
@github-actions github-actions bot added the RedM Issues/PRs related to RedM label Apr 27, 2024
@AvarianKnight AvarianKnight force-pushed the feat/rdr3-mono branch 2 times, most recently from 46ec5ae to 8bca1ff Compare April 27, 2024 05:56
@AvarianKnight
Copy link
Contributor Author

AvarianKnight commented Apr 27, 2024

This PR should be good to review.

The Goal of this PR is to implement some base classes for RedM to allow players who want to use it to get started.

Some of these methods were taken from the original FiveM classes, notably the Model class. Though this shouldn't have any have any int -> uint (or vice-versa) calls.

This was also why the Game.GenerateHash native is unique for RedM & FiveM.

This change set also introduces a UiFeed class so the user can generate feed messages, if wanted these changes can be pulled out to leave just the base classes being implemented.

@AvarianKnight
Copy link
Contributor Author

AvarianKnight commented Jun 11, 2024

Some changes that were made:

Model implements IDisposable so it will properly SetModelAsNoLongerNeeded when the object goes out of scope

Vehicle has more stuff implemented

Given recent events I likely wont work on this anymore so anyone can feel free to continue this PR if it needs changes.

@AvarianKnight AvarianKnight force-pushed the feat/rdr3-mono branch 2 times, most recently from bcae2e1 to a4f7deb Compare August 18, 2024 07:22
@github-actions github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged triage Needs a preliminary assessment to determine the urgency and required action and removed triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged labels Aug 18, 2024
Copy link
Contributor

@FabianTerhorst FabianTerhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution. Seems to work fine 👍

@FabianTerhorst FabianTerhorst added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action labels Aug 18, 2024
@prikolium-cfx prikolium-cfx merged commit 5139174 into citizenfx:master Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging RedM Issues/PRs related to RedM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants