Skip to content

tweak(cfx/nui): Hide server reviews *for now*#2979

Closed
outsider31000 wants to merge 4 commits into
citizenfx:masterfrom
outsider31000:master
Closed

tweak(cfx/nui): Hide server reviews *for now*#2979
outsider31000 wants to merge 4 commits into
citizenfx:masterfrom
outsider31000:master

Conversation

@outsider31000

Copy link
Copy Markdown
Contributor

Goal of this PR

server reviews are mostly a year old we could stop them from showing for now, until there's plans to bring them back.

How is this PR achieving the goal

Hidding reviews since they are a year old mostly.

This PR applies to the following area(s)

RedM/FiveM

Successfully tested on

Game builds: ..

Platforms: Windows, Linux

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@github-actions github-actions Bot added the triage Needs a preliminary assessment to determine the urgency and required action label Dec 4, 2024
@dalekenium-cfx dalekenium-cfx added status:needs planning Hard issues that take time as there's no 'one' obvious way. and removed triage Needs a preliminary assessment to determine the urgency and required action labels Dec 5, 2024
@PsychoShock

Copy link
Copy Markdown
Contributor

Instead of this, server owners should have the possibility to hide it with a convar. Some people might want to keep it.

@outsider31000

Copy link
Copy Markdown
Contributor Author

I agree a convar should be introduced.

If cfx made a poll about it I'm pretty sure no one would want server reviews , they are all toxic filled with lies.

Yo don't get things your way, they leave you a bad review.
You cheat they leave you a bad review.
Someone said no to you they leave you a bad review
And so on.

You can also tell people to leave a good review in exchange of something.

in my opinion it should be removed, server reviews aren't really credible.

@Lorenc95

Lorenc95 commented Dec 5, 2024

Copy link
Copy Markdown

I mostly have good experiences with reviews myself to be fair!
If a server is being unfair to their players, i will leave a review saying just that so others are aware!

If a server is doing something good on the other hand, the review will also mention that.

@outsider31000

Copy link
Copy Markdown
Contributor Author

Unfortunately not everyone has the same level of maturity. Server reviews aren't bad. They are just misused. And not credible.

@github-actions github-actions Bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Jan 30, 2025
@IgnornceIsBliss

Copy link
Copy Markdown

LGTM, No idea why this hasn't been bumped/merged since there's clearly no sign of them coming back anytime soon.

Please someone look at this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid Requires changes before it's considered valid and can be (re)triaged status:needs planning Hard issues that take time as there's no 'one' obvious way.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants