Skip to content

fix(extra-natives-five): fix DrawCorona param order in docs#3534

Merged
prikolium-cfx merged 1 commit into
citizenfx:masterfrom
cm8263:patch-1
Mar 2, 2026
Merged

fix(extra-natives-five): fix DrawCorona param order in docs#3534
prikolium-cfx merged 1 commit into
citizenfx:masterfrom
cm8263:patch-1

Conversation

@cm8263

@cm8263 cm8263 commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

Goal of this PR

Fix incorrect parameter order in docs for DrawCorona native.

How is this PR achieving the goal

Corrects the documentation.

This PR applies to the following area(s)

Documention

Successfully tested on

N/A

Checklist

  • [ N/A ] Code compiles and has been tested successfully.
  • [ Y ] Code explains itself well and/or is documented.
  • [ Y ] My commit message explains what the changes do and what they are for.
  • [ N/A ] No extra compilation warnings are added by these changes.

Fixes issues

Docs listed order as RGB then Alpha, when it is actually Alpha then RGB.

@github-actions github-actions Bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Jul 15, 2025
Docs listed order as RGB then Alpha, when it is actually Alpha then RGB.
@cm8263 cm8263 changed the title Fix incorrect parameter order for DrawCorona fix(extra-natives-five): fix DrawCorona param order in docs Jul 15, 2025
@github-actions github-actions Bot added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Jul 15, 2025
@cm8263

cm8263 commented Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

Not directly relevant, but also worth noting: there is a flags param for this native, and the docs contain an eCoronaFlags codeblock listing what the flags are; however, on the docs website, this eCoronaFlags codeblock is absent.

My best guess would be because the codeblock defines the language as cpp, and the docs website filters by Lua, C#, and JS, thus excluding CPP?

@utkuali

utkuali commented Dec 30, 2025

Copy link
Copy Markdown
Contributor

@Gogsi sorry, haven't seen it.

@radium-cfx radium-cfx added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action labels Jan 16, 2026
@prikolium-cfx prikolium-cfx merged commit 4bf3cd5 into citizenfx:master Mar 2, 2026
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR is enqueued for merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants