tweak(server/resources): remove legacy rdr3_warning requirement#3541
Closed
Ehbw wants to merge 1 commit into
Closed
tweak(server/resources): remove legacy rdr3_warning requirement#3541Ehbw wants to merge 1 commit into
Ehbw wants to merge 1 commit into
Conversation
Initially implemented with RedM server support, this warning has since become very outdated and has become a pointless burden when making new resources
github-actions
Bot
added
RedM
Collaborator
|
Thanks for your efforts, but RedM currently is not in release-ready state and this warning shouldn't be removed in this way. |
Contributor
|
what does RedM need to be considered as a release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Remove the legacy
rdr3_warningmanifest requirement when making client and server scripts for RedM.How is this PR achieving the goal
Removes logic that checks for and requires
rdr3_warningto be present with a very specific value in the manifest of each resource that supports game 'rdr3'.This PR applies to the following area(s)
RedM, Server
Successfully tested on
Game builds: 149i
Platforms: Windows
Checklist
Fixes issues
Comment brought up in Engineering Discord