fix(net/rdr3): verify net object model archetype#3550
Merged
prikolium-cfx merged 1 commit intoAug 6, 2025
Conversation
github-actions
Bot
added
RedM
| { | ||
| auto location = hook::get_pattern<char>("48 89 5C 24 ? 55 48 8B EC 48 83 EC ? E8 ? ? ? ? C7 45 ? ? ? ? ? 48 8D 55 ? C7 45 ? ? ? ? ? 8B 88"); | ||
| hook::set_call(&g_getPlayerSyncNodeData, location + 13); | ||
| MH_CreateHook(location, CPlayerCreationDataNode__CanApply, (void**)&g_origCPlayerCreationDataNode__CanApply); |
Collaborator
There was a problem hiding this comment.
Use trampoline please
Ehbw
force-pushed
the
fix/rdr3-net-tree-model-validation
branch
from
8b50445 to
84b6ec3
Compare
prikolium-cfx
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Backport 9cb9d15 and c0b8ca5 From FiveM in order to fix the same crashes/unintended behaviour in RedM.
How is this PR achieving the goal
Patching CanApply functions for Vehicle, Ped, Player and Animal Creation nodes in order to properly verify the models used. The game currently only checks if the model is valid but does not check if that model should be used for that entity type (e.g. ped model for a vehicle) leading to unintended behaviour and crashes.
This PR applies to the following area(s)
RedM
Successfully tested on
Game builds: 1491
Platforms: Windows, Linux
Checklist
Fixes issues