fix(gta-core-five): overriding ladder registers causing bad collision checks#3565
Merged
prikolium-cfx merged 1 commit intoAug 6, 2025
Merged
Conversation
prikolium-cfx
approved these changes
Aug 1, 2025
Contributor
|
tested on the specific branch an it works as expected! thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fix a issue with ladders that detect that some physical object is colliding in the test made by ladder logic, this only seems to happen in a custom map of NoPixel but very sure that can happen in ladders with same environment(cover above the end of ladder)
Clip: https://streamable.com/52f0it
How is this PR achieving the goal
I've checked and I was overwriting some registers that was used after, so here I'm restoring original rax value and r11 that is only used at the end for writing.
This PR applies to the following area(s)
FiveM
Successfully tested on
Can't test cause is in a custom map, can I get a feature branch to ask people with this issue to test if its working?
Game builds: ..
Platforms: Windows
Checklist
Fixes issues
Not public issue but reported by @d22tny