Skip to content

fix(gta-core-five): overriding ladder registers causing bad collision checks#3565

Merged
prikolium-cfx merged 1 commit into
citizenfx:masterfrom
DaniGP17:fix/ladder-overriding-register
Aug 6, 2025
Merged

fix(gta-core-five): overriding ladder registers causing bad collision checks#3565
prikolium-cfx merged 1 commit into
citizenfx:masterfrom
DaniGP17:fix/ladder-overriding-register

Conversation

@DaniGP17

@DaniGP17 DaniGP17 commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

Goal of this PR

Fix a issue with ladders that detect that some physical object is colliding in the test made by ladder logic, this only seems to happen in a custom map of NoPixel but very sure that can happen in ladders with same environment(cover above the end of ladder)
Clip: https://streamable.com/52f0it

How is this PR achieving the goal

I've checked and I was overwriting some registers that was used after, so here I'm restoring original rax value and r11 that is only used at the end for writing.

This PR applies to the following area(s)

FiveM

Successfully tested on

Can't test cause is in a custom map, can I get a feature branch to ask people with this issue to test if its working?
Game builds: ..
Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

Not public issue but reported by @d22tny

@prikolium-cfx prikolium-cfx added the ready-to-merge This PR is enqueued for merging label Aug 1, 2025
@github-actions github-actions Bot added the triage Needs a preliminary assessment to determine the urgency and required action label Aug 1, 2025
@d22tny

d22tny commented Aug 3, 2025

Copy link
Copy Markdown
Contributor

tested on the specific branch an it works as expected! thanks.

@prikolium-cfx prikolium-cfx merged commit 8abc342 into citizenfx:master Aug 6, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR is enqueued for merging triage Needs a preliminary assessment to determine the urgency and required action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants