Skip to content

feat(graphics/rdr3): graphics improvements v3#4045

Open
Ehbw wants to merge 3 commits into
citizenfx:masterfrom
Ehbw:feat/rdr3-graphics-improvements-v3
Open

feat(graphics/rdr3): graphics improvements v3#4045
Ehbw wants to merge 3 commits into
citizenfx:masterfrom
Ehbw:feat/rdr3-graphics-improvements-v3

Conversation

@Ehbw

@Ehbw Ehbw commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Goal of this PR

third time's a charm. Reapplies #4033 with additional fixes to combat issues that were reported with the previous iteration of these changes.

  • Introduce fallback logic for cases where the GPU claims to support 'VK_KHR_external_memory_win32' but then doesn't implement/support 'vkGetMemoryWin32HandlePropertiesKHR' (thanks nvidia)
  • Clean-up SRV's created for NUI. These SRV's weren't being properly released/recycled back into a pool in the case of DX12.

How is this PR achieving the goal

This PR applies to the following area(s)

RedM

Successfully tested on

Game builds: 1491

Platforms: Windows, Linux

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

Ehbw added 3 commits June 19, 2026 16:05
On some system configurations a GPU can report as supporting 'VK_KHR_external_memory_win32' but not implement functions from it such as 'vkGetMemoryWin32HandlePropertiesKHR' which would lead to a crash as we expect this to alwayhs be available under vulkan
@github-actions github-actions Bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid Requires changes before it's considered valid and can be (re)triaged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant