refactor(core): replace unicode-emoji-json with native RGI_Emoji regex#1100
Open
Syxless wants to merge 1 commit into
Open
refactor(core): replace unicode-emoji-json with native RGI_Emoji regex#1100Syxless wants to merge 1 commit into
Syxless wants to merge 1 commit into
Conversation
Use the native /\p{RGI_Emoji}/v regex available since Node 20+ instead
of the manual codepoint ranges in cleanPlayerName and the unicode-emoji-json
library in discordHelpers. This removes a dependency while improving emoji
detection accuracy.
Syxless
force-pushed
the
refactor/native-emoji-regex
branch
from
ab43970 to
9598273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes a TODO from dev-notes.md under "After Node 22" - use
/^\p{RGI_Emoji}$/vto detect emojis and removeunicode-emoji-jsonfrom dependencies.