-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/core#5335 - Only show pcp section on online receipt if there is a pcp #30628
Conversation
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5335 |
The test fail is |
// Only display PCP block in receipt if enabled for the PCP page | ||
if (!empty($pcpDAO->is_honor_roll)) { | ||
$pcpParams['pcpBlock'] = TRUE; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@demeritcowboy I am just wondering is pcpBlock assigned as FALSE by default at all anywhere? just thinking it would be good to have it always assigned to the template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up a few lines it is set to null
Sorry got interrupted saving so I don't close the window and loose this!
|
Overview
https://lab.civicrm.org/dev/core/-/issues/5335
Before
To reproduce you can set up an online contribution page but it's easier to see the problem like so:
After
Better.
Technical Details
The logic is backwards. See ticket.
Also when pcp_id is null the find() would pick up the first arbitrary pcp page when there is one. null doesn't mean none it means wildcard.
Comments
Slightly easier to review with whitespace hidden.