Follow up fixes on population of new civicrm_mailing fields #30648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
wmfgerrit
pushed a commit
to wikimedia/wikimedia-fundraising-crm
that referenced
this pull request
Jul 10, 2024
https: //github.com/civicrm/civicrm-core/pull/30648 Bug: T368999 Change-Id: I8583387732bddf61255572e26726a4097b9c4744
| @@ -33,7 +33,7 @@ public function upgrade_5_76_alpha1($rev): void { | |||
| $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev); | |||
| $this->addTask('Add start_date to civicrm_mailing table', 'addColumn', 'civicrm_mailing', 'start_date', "timestamp NULL DEFAULT NULL COMMENT 'date on which this mailing was started.'"); | |||
| $this->addTask('Add end_date to civicrm_mailing table', 'addColumn', 'civicrm_mailing', 'end_date', "timestamp NULL DEFAULT NULL COMMENT 'date on which this mailing was completed.'"); | |||
| $this->addTask('Add status to civicrm_mailing table', 'addColumn', 'civicrm_mailing', 'status', "varchar(12) DEFAULT NULL COMMENT 'The status of this Mailing'"); | |||
| $this->addTask('Add status to civicrm_mailing table', 'addColumn', 'civicrm_mailing', 'status', "varchar(12) DEFAULT 'Draft' COMMENT 'The status of this Mailing'"); | |||
There was a problem hiding this comment.
Should the length be 12 or 32? In a stock 5.76 install it's 32, although oddly has maxlength 12:
civicrm-core/schema/Mailing/Mailing.entityType.php
Lines 425 to 427 in f6718f2
There was a problem hiding this comment.
@demeritcowboy OK - I'll go with 32 for maxlength & here - seems like that makes sense
|
thanks @demeritcowboy |
|
This has been confusing me since yesterday as to why it wasn't crashing for me earlier. It does appear that at one point this PR had |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a follow on to #30458
After deploying the rc on our staging I discovered a couple of gaps
statusfield has a default value in the schema but not the upgrade scriptcivicrm_mailing_jobset to 'Complete' but theis_completedfield was not set to TRUEBefore
some rows had
statusof NULL after the upgradeAfter
statusTechnical Details
There was no noticeable time cost running this script on our staging site - unlike the the prior mailing table upgrades this script deals with the number of mailings & mailing jobs, not the recipients.
Comments