[REF] Fix empty link accessibility issues in nav menu by setting scre…

[seamuslee001]

No description provided.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[monishdeb]

@seamuslee001 does this PR provides a alternative fixes to https://github.com/civicrm/civicrm-core/pull/30676/files ?

[seamuslee001]

@monishdeb the first part i think is redundant with your PR the 2nd part of the patch seems to be needed because I see
even with your PR applied on our test site and also the 3rd part is needed for the logo as I see

if I remove the 3rd part of the patch

[monishdeb]

I see can you also include this portion on your PR :

diff --git a/js/crm.menubar.js b/js/crm.menubar.js
index 357331f382f..fa190fdd139 100644
--- a/js/crm.menubar.js
+++ b/js/crm.menubar.js
@@ -287,6 +287,7 @@
     initializeSearch: function() {
       $('input[name=qfKey]', '#crm-qsearch').attr('value', CRM.menubar.qfKey);
       $('#crm-qsearch-input')
+        .attr('title', ts('Name/Email'))
         .autocomplete({
           source: function(request, response) {

so that I can close #30676 ?

[seamuslee001]

I see can you also include this portion on your PR :

diff --git a/js/crm.menubar.js b/js/crm.menubar.js
index 357331f382f..fa190fdd139 100644
--- a/js/crm.menubar.js
+++ b/js/crm.menubar.js
@@ -287,6 +287,7 @@
     initializeSearch: function() {
       $('input[name=qfKey]', '#crm-qsearch').attr('value', CRM.menubar.qfKey);
       $('#crm-qsearch-input')
+        .attr('title', ts('Name/Email'))
         .autocomplete({
           source: function(request, response) {

so that I can close #30676 ?

No these are complimentary now hopefully

[monishdeb]

I am wrong in my assumption, the title set to Name/Email is wrong where these could dynamically change in here . Closing my PR #30676 . I would create a separate PR only for that a11y fix.

[monishdeb]

@seamuslee001 can you add closing </span> tag? that is missing here.

[vingle]

test this please

[vingle]

As @monishdeb says, this lacks a closing span but the browser seems to add it, I think because it's wrapped in an <a>.

This only fixes one of the two empty link errors on the navbar for me now, the first search box still gives one:

I think one of the fixes in the now closed PR from Monish (maybe this line?) would resolve that.