Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Fix Screen reader accessibility of attachment fields #30690

Merged

Conversation

seamuslee001
Copy link
Contributor

Overview

This ensures that each file field correctly has a label assigned to it for screen readers and the description field is also properly labelled

Before

Labels incorrectly referencing attachfile_1 and no label on description fields

After

labels fixed

@monishdeb @eileenmcnaughton @colemanw @JoeMurray

Copy link

civibot bot commented Jul 17, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@eileenmcnaughton
Copy link
Contributor

@vingle

@vingle
Copy link
Contributor

vingle commented Jul 18, 2024

Test this please

@vingle
Copy link
Contributor

vingle commented Jul 18, 2024

This reads like a good improvement, but haven't tested.

@vingle
Copy link
Contributor

vingle commented Aug 16, 2024

test this please

@vingle
Copy link
Contributor

vingle commented Aug 16, 2024

Works for me: improves accessibility and functionality isn't impacted. Good to go.

image

@eileenmcnaughton eileenmcnaughton merged commit 5024f05 into civicrm:master Aug 16, 2024
1 check passed
@eileenmcnaughton eileenmcnaughton deleted the attachment_accessbility branch August 16, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants