Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Get rid of hidden submit button no longer used in report #30692

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented Jul 17, 2024

Overview

Get rid of hidden submit button no longer used in report. Earlier this button was jointly works with Add Contacts to Group action but now this button is no longer used and hidden. This trigger a accessibility issue shown under before section.

Before

Screenshot 2024-07-17 at 09 58 29

After

Fixed

Comments

ping @colemanw @seamuslee001

Copy link

civibot bot commented Jul 17, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Jul 17, 2024
@colemanw colemanw merged commit 24cde3c into civicrm:master Jul 17, 2024
1 check passed
@monishdeb monishdeb deleted the a11y_fixes_report_1 branch July 17, 2024 14:59
@demeritcowboy
Copy link
Contributor

This doesn't seem to be unused. I'm seeing some test fails and also just try choosing Add Contacts to Group from a civireport, plus the php warnings on screen running a civireport. @monishdeb @colemanw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants