fixes fatal error while loading smart group with deleted custom field #30699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
colemanw
reviewed
Jul 17, 2024
| @@ -562,6 +562,9 @@ public static function getKeyID($key, $all = FALSE) { | |||
| * @throws CRM_Core_Exception | |||
| */ | |||
| public static function getFieldObject($fieldID) { | |||
| if (empty(self::getField($fieldID))) { | |||
| return; | |||
| } | |||
| $field = new CRM_Core_BAO_CustomField(); | |||
| $field->copyValues(self::getField($fieldID)); | |||
There was a problem hiding this comment.
I'd change this to a variable so the getField function doesn't have to be called twice.
|
@kurund this function is marked |
It is called by https://github.com/civicrm/civicrm-core/blob/master/CRM/Contact/BAO/Query.php#L4768 in my Civi instance (CiviCRM v5.71.2) Code is changed in master. There are still few instances of |
|
May be we can close this. |
|
this was fixed in #30104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.