Prevent error when exporting with household relationship types disabled

[larssandergreen]

Before

If you disable household relationship types, exporting contacts will fail if you try to merge contacts with the same address.

After

Works.

Technical Details

The code was returning [[0] => [1] => ] which was later producing borked SQL because there was no $id.

You might ask why $isMergeSameHousehold is true when we are merging by shared address and not household? Apparently, same address implies household as well.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[demeritcowboy]

In all the installs I look at these relationship types are reserved, so I can only disable them in api explorer or db. But ok assuming you do that and want to feel the wrath of civi, this seems a simple enough way to handle it. I note the number of contacts you get is the same but the list of contacts you get is slightly different - it seems inconsistent about whether to export the household or one of the people, but maybe that was never guaranteed anyway.

[larssandergreen]

Thanks @demeritcowboy. I guess I just hate households so much that I really want them gone as much as possible.

[demeritcowboy]

Lars the homewrecker (grin)