-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Depends on civicrm-core#25414 Output pre-upgrade message when u… #663
base: 7.x-master
Are you sure you want to change the base?
Conversation
…pgrading civicrm db using drush
(Standard links)
|
I ran this in combination with the core PR, with an upgrade from 5.51=>master[5.59ish]. Here's how the output looked:
This is a bit incongruous in that:
If you look at a bit closer, the The |
If you use civicrm/civicrm-core#25488 and the following patch, then the output will be a bit more consistent. diff --git a/drush/civicrm.drush.inc b/drush/civicrm.drush.inc
index a63976a..145ab99 100644
--- a/drush/civicrm.drush.inc
+++ b/drush/civicrm.drush.inc
@@ -741,10 +741,10 @@ function drush_civicrm_upgrade_db() {
return TRUE;
}
$upgradeHeadless = new CRM_Upgrade_Headless();
- drush_print("Pre Upgrade Message:\n" . $upgradeHeadless->getPreUpgradeMessage());
+ drush_print("Pre-Upgrade Messages:\n" . $upgradeHeadless->getPreUpgradeMessage()['text']);
// FIXME Exception handling?
$result = $upgradeHeadless->run();
- drush_print("Upgrade outputs:\n" . $result['text']);
+ drush_print("Post-Upgrade Messages:\n" . $result['text']);
}
/** |
yeh ok @totten that makes sense I'll add this in tomorrow my time and we can merge this and i'll do similar for wp-cli |
OK, sounds good |
…pgrading civicrm db using drush
ping @demeritcowboy @totten