Use the deleted file list to remove old files after installation #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. I think this will work with the files in the list but not the directories. Directory paths in |
Oh - missed that! I'll work something up with a |
|
Yes, this would be very valuable! |
|
Hi , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Using the deleted files list from civicrm/civicrm-core#28653, the Joomla installers will now remove files from the filesystem that don't exist in the version being installed.
Before
The default Joomla installation process doesn't delete files on upgrade. This leads to outdated files that at best don't do anything and at worst can cause fatal errors.
After
The Joomla installation process now deletes files based on the deleted-files-list.json