Allow more dynamic properties #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@spalmstr I've been digging a bit on Smarty & looks like we can push through to Smarty 4 - which hopefully doesn't have any remaining php compatibility issues - https://lab.civicrm.org/dev/core/-/issues/4954 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Later versions of PHP deprecate having dynamic variables in the class constructors and CiviCRM complains when they are used. This PR allows the 'offending' code to use dynamic variables in the constructors, since, without knowing the code, it is possible that the same variable will have different properties depending on how it is called. Obviously, it would be better to declare them if one knew how it was being used.