Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enabling smarty escape by default with Smarty5 #409

Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jun 29, 2024

This makes Smarty5 respect the constant CIVICRM_SMARTY_DEFAULT_ESCAPE - this was something we were close to getting viable with Smarty2 but put on hold in order to work on updating smarty. It is not an option for Smarty3 & 4 & has no production usage in 2 but with this it can be enabled on 5 & with civicrm/civicrm-core#30566 it loads without crashing

civicrm/civicrm-core#30567 & a larger one doing the same thing are required to get it to not have UI issues

I kept the class in packages as the main Smarty class is currently there to avoid conflict & it feels sane to keep it together - at some point we would move it to \Civi\Smarty5\ I think but we need to cull smarty versions first

Copy link

civibot bot commented Jun 29, 2024

(Standard links)

@civibot civibot bot added the master label Jun 29, 2024
@seamuslee001 seamuslee001 merged commit c5c9610 into civicrm:master Aug 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants