Allow enabling smarty escape by default with Smarty5 #409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Smarty5 respect the constant
CIVICRM_SMARTY_DEFAULT_ESCAPE
- this was something we were close to getting viable with Smarty2 but put on hold in order to work on updating smarty. It is not an option for Smarty3 & 4 & has no production usage in 2 but with this it can be enabled on 5 & with civicrm/civicrm-core#30566 it loads without crashingcivicrm/civicrm-core#30567 & a larger one doing the same thing are required to get it to not have UI issues
I kept the class in packages as the main
Smarty
class is currently there to avoid conflict & it feels sane to keep it together - at some point we would move it to\Civi\Smarty5\
I think but we need to cull smarty versions first