Add Smarty php8.4 support #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is from a currently open PR smarty-php/smarty#1043 I think we can merge this to see our 8.4 start running & be relaxed if we lose it temporarily if we update Smarty again now before it is merged (which seems unlikely but we can hopefully hustle the merge)
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is from a currently open PR
smarty-php/smarty#1043
I think we can merge this to see our 8.4 start running & be relaxed if we lose it temporarily
if we update Smarty again now before it is merged (which seems unlikely but we can hopefully hustle the merge)
Note patch includes an update to latest released smarty which I can rebase out once merged #411