(Future work) Define statement-level helper (Top) to bypass prefixing
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `cv` has a list of php-scoper rules to exclude certain classes from prefixing.
The same list has to be adapted to use in `civix` - so, presumbly, they'll have to be
sync'd over time.
The main reason for this is to allow the PHAR to call-out to the UF during bootstrap -- and
each UF has a different list of rules.
In theory, we could drop these rules -- and replace any lines like
`drupal_bootstrap()` with `Top::call('drupal_bootstrap')`. Then there would be no
need to keep the rules in sync.
Additionally, it would allow `cv.phar` to take advantage of libraries (like `symfony/event`)
that might be dual-purpose. (Ex: cv.phar and UF both have `EventDispatcher`s; and you want
to add listeners to both of them.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft towards simplify
scoper.inc.php. I don't need the simplification at quite this minute, and it would need some more work/testing. But I want to keep the patch around as a reminder for how to do it (*the next thatscoper.inc.phpcomes to mind).Before
Bootstrap.phpandCmsBootstrap.phpneed to reference various UF symbols (drupal_foobar,JFactory,wp_*, etc.)scoper.inc.phphas a bunch of exclusions so that namespace-prefixes are not applied to these symbols.cv.gitandcivix.git.After
Bootstrap.phpandCmsBootstrap.php' reference various UF symbols (Top::call('drupal_foobar'),Top::call('JFactory::getUser')`, etc)scoper.inc.phpdon't need those exclusions.TODO
Patch currently defines the
Tophelper. Next: Swap the various calls inBootstrap.phpandCmsBootstrap.phpto useTop. Remove the rules. Re-tests both cv and civix.