quote MySQL password #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totten
reviewed
Feb 11, 2020
| @@ -137,7 +137,7 @@ public function toMySQLArguments($tmpDir) { | |||
| $data = "[client]\n"; | |||
| $data .= "host={$this->host}\n"; | |||
| $data .= "user={$this->username}\n"; | |||
| $data .= "password={$this->password}\n"; | |||
| $data .= "password='{$this->password}'\n"; | |||
There was a problem hiding this comment.
Good idea.
I suppose one could have a password with a quote mark? Do you happen to know what escaping rules they use MySQL's file-format? Maybe addslashes() or addcslashes() would come closer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have globbing characters (e.g.
*) in your MySQL password,cvwill fail to connect. Quoting the password in the generateddefaults-filefixes the problem and seems to have no ill effect.