This repository was archived by the owner on Aug 29, 2020. It is now read-only.
Fix crash if, for any reason, there are no processes to list#102
Open
CosmicHorrorDev wants to merge 1 commit intocjbassi:masterfrom
Open
Fix crash if, for any reason, there are no processes to list#102CosmicHorrorDev wants to merge 1 commit intocjbassi:masterfrom
CosmicHorrorDev wants to merge 1 commit intocjbassi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #99 there was an issue where
self.procswas occasionally empty causing the program to crash when trying to index for the selected process. This is likely due to some issue inpsutilsince the process list is provided by thepsutil::process::ProcessCollectorand shouldn't ever reasonably be empty. This also sets up the program better for if process filtering is established since a filter could easily yield no processes and would still have to display without crashing.