This repository was archived by the owner on Aug 29, 2020. It is now read-only.
Ignore bond as well as tun for network activity#95
Open
CosmicHorrorDev wants to merge 2 commits intocjbassi:masterfrom
Open
Ignore bond as well as tun for network activity#95CosmicHorrorDev wants to merge 2 commits intocjbassi:masterfrom
bond as well as tun for network activity#95CosmicHorrorDev wants to merge 2 commits intocjbassi:masterfrom
Conversation
… to double counting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #92
The network graph already had logic to ignore just
tun0. However, having multipletuns or in the case of #92 having abondwill still cause the problem of counting for the virtual and physical network device. This change just changes the logic to ignore all tunnels and bonds.Just as a note for future work it would be nice to have a way of detecting and filtering out virtual devices instead of dealing with all of these cases separately, but it looks like
rust-psutildoesn't have that functionality yet.