Skip to content

fix #38 Save a reportfile even when there are no problems #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Crydust wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #38 Save a reportfile even when there are no problems #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/cj/jshintmojo/Mojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,8 @@ private void handleResults(final Map<String, Result> currentResults,
}
}

saveReportFile(currentResults, reporter, reportFile);
if(numProblematicFiles > 0) {
saveReportFile(currentResults, reporter, reportFile);

String errorMessage = "\nJSHint found problems with " + numProblematicFiles + " file";

Expand Down
19 changes: 19 additions & 0 deletions src/test/java/com/cj/jshintmojo/MojoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,25 @@ public void walksTheDirectoryTreeToFindAndUseJshintFiles() throws Exception {
}
}
}

@Test
public void savesReportEvenWhenThereAreNoProblems() throws Exception {
// given
File directory = tempDir();
File reportFile = new File(directory, "reportFile");

LogStub log = new LogStub();
Mojo mojo = new Mojo("", "",
directory,
Collections.singletonList(""),
Collections.<String>emptyList(),true, null, "jslint", reportFile.getAbsolutePath(), null);
mojo.setLog(log);
// when
mojo.execute();
// then
assertTrue("Saves report", log.hasMessage("info",
"Generating \"JSHint\" report. reporter=jslint, reportFile="+reportFile.getAbsolutePath()+"."));
}

@Test
public void warnsUsersWhenConfiguredToWorkWithNonexistentDirectories() throws Exception {
Expand Down