1 Warning and 1 Error fixes for Java version

[eax]

fixes:

1. bootstrap class path not set in conjunction with -source 1.5 warning for JDK7 on Mac.
2. m4 comment EOF error (ERROR: end of file in comment)

[cjlin1]

Ekrem Aksoy writes:

fixes:

1. bootstrap class path not set in conjunction with -source 1.5 warning
   for JDK7 on Mac.
   some users don't have 1.7, so we won't change this at this moment

2. m4 comment EOF error (ERROR: end of file in comment)

   what's this? I don't quite understand

You can view, comment on, or merge this pull request online at:

#25

Commit Summary

• suppress bootstrap class path not set in conjunction with -source 1.5
  warning and fix m4 comment EOF error

File Changes

• M java/Makefile (2)
• M java/libsvm/svm.m4 (2)

Patch Links:

• https://github.com/cjlin1/libsvm/pull/25.patch
• https://github.com/cjlin1/libsvm/pull/25.diff

—
Reply to this email directly or view it on GitHub.*

[eax]

When I've cloned repo, I've tried to compile java version (make clean && make), however it complained

m4 libsvm/svm.m4 > libsvm/svm.java
m4:libsvm/svm.m4:9: ERROR: end of file in comment
make: *** [libsvm/svm.java] Error 1

It is M4 error such as if you omit closing comment option, it puts EOF character. I've just fixed that.

(GNU M4 1.4.6 version on Macosx 10.7.5)

[cjlin1]

-changecom(//', ) +changecom(//', ` ')

shouldn't ' be'? (i.e., no space)

[eax]

Yep, it work in both ways, but I just want to highlight it.

-EA

On Sat, Apr 4, 2015 at 8:58 AM, cjlin1 [email protected] wrote:

-changecom(//', ) +changecom(//', ` ')

shouldn't ' be'? (i.e., no space)

—
Reply to this email directly or view it on GitHub
#25 (comment).

[cjlin1]

Thanks. But with a space it means things between // and a space. I think we want // and the end of a line. In this regard, we shouldn't have a space, right?

Ekrem Aksoy writes:

Yep, it work in both ways, but I just want to highlight it.

-EA

On Sat, Apr 4, 2015 at 8:58 AM, cjlin1 [email protected] wrote:

-changecom(//', ) +changecom(//', ` ')

shouldn't ' be'? (i.e., no space)

—
Reply to this email directly or view it on GitHub
#25 (comment).

—
Reply to this email directly or view it on GitHub.*

[cjlin1]

We have now used
changecom(//',')
This will appear in the next release. Thanks

Ekrem Aksoy writes:

When I've cloned repo, I've tried to compile java version (make clean && make),
however it complained

m4 libsvm/svm.m4 > libsvm/svm.java
m4:libsvm/svm.m4:9: ERROR: end of file in comment
make: *** [libsvm/svm.java] Error 1

It is M4 error such as if you omit closing comment option, it puts EOF character.
I've just fixed that.

(GNU M4 1.4.6 version on Macosx 10.7.5)

—
Reply to this email directly or view it on GitHub.*