Separate configuration for styles in ol and ul list properties
#16614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkflpc
reviewed
Jun 28, 2024
| * | ||
| * @default [] | ||
| */ | ||
| exclude?: Array<'ul' | 'ol'>; |
There was a problem hiding this comment.
- Why exclude? Is opt-out really preferred over opt-in?
- I know using 'ul' and 'ol' was suggested in ticket comment, but those lists are named 'bulleted' and 'numbered'.
- How above points play with multi-level lists? Does both make sense if this plugin is also present?
There was a problem hiding this comment.
- I think opt-out would be more preferable, because of keeping backward compatibility, if users want to have styles for both types of list they need to update their configs.
- Sure, I think it's a good idea with using
bulletedandnumberedlist 🙂. - Multi level list it's a separate feature and AFAIK multi level list doesn't have any styles at the moment, then I didn't consider this type of list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (List): Extend
ListPropertiesStyleConfiginterface with excluding list type option. Closes #15554.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.