Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dependencies and reduced min sdk to 15 #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kibotu
Copy link

@kibotu kibotu commented Oct 26, 2016

No description provided.

@cketti
Copy link
Owner

cketti commented Oct 26, 2016

Thank you for trying to contribute. However, there are a couple of issues with this pull request:

  • minSdkVersion 16 was chosen deliberately because that's the first Android version that properly handles URI permissions with a content:// URI in EXTRA_STREAM
  • I don't want to use snapshot versions of libraries
  • There are some unrelated and unwanted changes (the Jitpack link, commented out android-mvn-push.gradle script)

Generally, I prefer pull requests that change just one thing, not multiple things at once.

@kibotu
Copy link
Author

kibotu commented Oct 26, 2016

thanks for the feedback, generelly i just wanted to share the update of all dependencies

minSdkVersion 16 was chosen deliberately because that's the first Android version that properly handles URI permissions with a content:// URI in EXTRA_STREAM

in my opinion this should be a passive requirement not a hard one, because applications lower than 16 couldn't even compile due to manifest merging, even though just this one feature is not supported below 16 for stated reasons

I don't want to use snapshot versions of libraries
jitpack is mainly based on tags and less about snapshots, although both are possible

There are some unrelated and unwanted changes (the Jitpack link, commented out android-mvn-push.gradle script)

i prefer to your maven depency but i can't use it since i don't own the credentials, so feel free to re-add it, it's just jitpack couldn't build and i sort of needed this library now. also the library hasn't been updated in quite a while so, forgive me for assuming the pull request might take a while to be considered

other than that, neat library, thanks for sharing, stay awesome~

@cketti
Copy link
Owner

cketti commented Oct 26, 2016

If you really have to, you can override the library's minSdkVersion. See tools:overrideLibrary-marker.

The snapshot comment was because of the inclusion of Sonatype's snapshot repository and testCompile 'org.robolectric:robolectric:3.2-SNAPSHOT'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants