rfc: odi and poa in vp - #21
Open
robdefeo wants to merge 2 commits into
Open
Conversation
robdefeo
commented
Dec 12, 2024
| "credentialSchema": { | ||
| "id": "https://api-pilot.ebsi.eu/trusted-schemas-registry/v3/schemas/z2sbTT23X2zfsdMCPFMC7GiUwyHE91Lg9BpeEA5uqtT9s", | ||
| "type": "FullJsonSchemaValidator2021" | ||
| "type": ["VerifiablePresentation"], |
Collaborator
Author
There was a problem hiding this comment.
Could include another type in this array ["VerifiablePresentation", "IncludedODI"] or ["VerifiablePresentation", "LinkedODI"] name is not good but indicates to the validator to look for the ODI in the VP or for a linked ODI. This will also remove the issue of where to look for the ODI as the the POA or the presentation indicates what ODI to use.
robdefeo
commented
Dec 12, 2024
| "path": [ | ||
| "$.type" | ||
| ], | ||
| "optional": true, |
Collaborator
Author
There was a problem hiding this comment.
This indicates that this credential is optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to think a little more widely about how to solve the problem of including an ODI with a POA. This is one a those approaches along with #20.
This PR proposes to include both the ODI and POA when presenting credentials. This matches well with the pattern of authorising and action based on multiple credentials.
If we choose to go down this root, we can evaluate if we give different names to the linked/included ODI which would make clearer where to look for the proof and allow relying parties to choose what method(s) they would accept for ODI.