Conversation
pksunkara
force-pushed
the
color-enum
branch
2 times, most recently
from
8283a0b to
8fbed8b
Compare
epage
reviewed
Oct 11, 2021
epage
previously requested changes
Oct 11, 2021
Member
epage
left a comment
epage
left a comment
There was a problem hiding this comment.
Runtime support for Never is needed.
pksunkara
force-pushed
the
color-enum
branch
2 times, most recently
from
fce9d21 to
6062970
Compare
Member
Author
|
@epage Can you look at the API? I will add docs if good. |
epage
approved these changes
Oct 12, 2021
Member
Author
|
Updated. |
epage
changed the title
epage
approved these changes
Oct 13, 2021
Member
epage
left a comment
epage
left a comment
There was a problem hiding this comment.
Did a rough pass at title / summary just to avoid it falling through the cracks. Feel free to correct anything and have bors kick things off.
Member
Author
|
bors r+ |
Contributor
|
Build failed: |
Member
Author
|
bors retry |
Contributor
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Contributor
|
Build succeeded: |
epage
added a commit
to epage/clap
that referenced
this pull request
Nov 11, 2021
In clap-rs#2851, we moved color from an AppSetting to function (with some tweaks in clap-rs#2907). When doing this, we documented `App::color` to be equivelant of `App::global_settings(Color...)` but never actually propogated it. We are now propogating it. A test is added to ensure that no matter how we store the color choice, we continue to propogate it. This required exposing `App::get_color`.
epage
added a commit
to epage/clap
that referenced
this pull request
Nov 11, 2021
In clap-rs#2851, we moved color from an AppSetting to function (with some tweaks in clap-rs#2907). When doing this, we documented `App::color` to be equivalent of `App::global_settings(Color...)` but never actually propagated it. We are now propagating it. A test is added to ensure that no matter how we store the color choice, we continue to propagate it. This required exposing `App::get_color`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches us from individual
AppSettingsfor each state to an enumWe did not provide yaml support, assuming this is more of a runtime decision while yaml is more static.
Fixes #2811